Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JDK 17 #4085

Closed
1 of 10 tasks
mikeharder opened this issue Sep 15, 2021 · 21 comments
Closed
1 of 10 tasks

Add JDK 17 #4085

mikeharder opened this issue Sep 15, 2021 · 21 comments
Assignees
Labels
Area: Java awaiting-deployment Code complete; awaiting deployment and/or deployment in progress feature request

Comments

@mikeharder
Copy link

Tool name

openjdk version "17"

Tool license

GPLv2+CE

Add or update?

  • Add
  • Update

Desired version

latest

Approximate size

No response

Brief description of tool

No response

URL for tool's homepage

No response

Provide a basic test case to validate the tool's functionality.

No response

Virtual environments affected

  • Ubuntu 16.04
  • Ubuntu 18.04
  • Ubuntu 20.04
  • macOS 10.15
  • macOS 11
  • Windows Server 2016
  • Windows Server 2019
  • Windows Server 2022

Can this tool be installed during the build?

No response

Tool installation time in runtime

No response

Are you willing to submit a PR?

No response

@miketimofeev
Copy link
Contributor

Hi @mikeharder!
We are currently switching our pre-installed Java to adoptium openjdk — #3859
We will add Java 17 LTS once installers are available for adoptium adoptium/adoptium#74

@mikhailkoliada
Copy link
Contributor

Windows and MacOS are done, jdk 17 should be available there as soon as new images are deployed next week

@wimdeblauwe
Copy link

What about Linux ?

@mvysny
Copy link

mvysny commented Sep 30, 2021

@wimdeblauwe for me it works well with ubuntu-latest and jdk17, please see an example here: https://github.com/mvysny/karibu-tools/blob/main/.github/workflows/gradle.yml

@miketimofeev
Copy link
Contributor

@wimdeblauwe we are waiting for adoptium linux installers adoptium/installer#330

@mikhailkoliada
Copy link
Contributor

Windows and MacOS are done, jdk 17 should be available there as soon as new images are deployed next week

Both are in place by now.

devinrsmith added a commit to devinrsmith/deephaven-core that referenced this issue Nov 1, 2021
By choosing a less specific version, we can take advantage of the pre-installed JVMs as part of the Github runner's image, https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md#java.

In that vein as well, "AdoptOpenJDK" is now "Adoptium" / "Temurin", and so to take advantage of cache we need to choose that.

JDK 17 should be pre-installed as part of actions/runner-images#4085

See https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/

Follow up, deephaven#1513
devinrsmith added a commit to deephaven/deephaven-core that referenced this issue Nov 1, 2021
By choosing a less specific version, we can take advantage of the pre-installed JVMs as part of the Github runner's image, https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md#java.

In that vein as well, "AdoptOpenJDK" is now "Adoptium" / "Temurin", and so to take advantage of cache we need to choose that.

JDK 17 should be pre-installed as part of actions/runner-images#4085

See https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/

Follow up, #1513
@tinolazreg
Copy link

Any status updates on Linux?

@miketimofeev
Copy link
Contributor

@tinolazreg still waiting for adoptium binaries adoptium/installer#330

@Davio
Copy link

Davio commented Dec 16, 2021

@tinolazreg still waiting for adoptium binaries adoptium/installer#330

This issue seems close to completion, I wonder when this will be complete.

@miketimofeev
Copy link
Contributor

@Davio thanks for the update! We will get back to this soon

@miketimofeev
Copy link
Contributor

@Davio we will postpone this as it is said

the installers are not stable and the hostname will change from adoptium.jfrog.io to packages.adoptium.net.

adoptium/installer#346 (comment)

@m0dul3
Copy link

m0dul3 commented Jan 6, 2022

accept

@mikhailkoliada
Copy link
Contributor

The Linux installer (the last one) has been merged, the images with the Eclipse Temurin 17 jdk will be deployed next week.

@mikhailkoliada mikhailkoliada added the awaiting-deployment Code complete; awaiting deployment and/or deployment in progress label Jan 12, 2022
@martoncsukas
Copy link

martoncsukas commented Jan 19, 2022

Hi @mikhailkoliada , any ETA on when JDK 17 be available in the ubuntu-latest image for Azure DevOps? Thanks in advance.

@miketimofeev
Copy link
Contributor

@martoncsukas the new image is currently being deployed. Some environments already have JDK17 the rest will have it tomorrow.

@Davio
Copy link

Davio commented Jan 20, 2022

It seems like most of the code is in place, but the README(s), such as https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-Readme.md still need to be amended.

@miketimofeev
Copy link
Contributor

@Davio Ubuntu20.04 is not yet updated. Will be finished next week

@Davio
Copy link

Davio commented Jan 20, 2022

It seems like the scripts were already fixed though, is it just a matter of deployment now?

@miketimofeev
Copy link
Contributor

@Davio correct

@Davio
Copy link

Davio commented Jan 24, 2022

It seems like the Ubuntu agents have been updated, thanks for all the hard work everyone. :)

@mikhailkoliada
Copy link
Contributor

Yes, everything has been deployed, closing now.

Fei1Yang added a commit to feiyangprojects/minecraftmod-notelemetry that referenced this issue Apr 16, 2022
This pipeline should only be started after upstream release new runner templates[1] with Java 17 installed.
[1]: actions/runner-images#4085 [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Java awaiting-deployment Code complete; awaiting deployment and/or deployment in progress feature request
Projects
None yet
Development

No branches or pull requests

10 participants