-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JDK 17 #4085
Comments
Hi @mikeharder! |
Windows and MacOS are done, jdk 17 should be available there as soon as new images are deployed next week |
What about Linux ? |
@wimdeblauwe for me it works well with ubuntu-latest and jdk17, please see an example here: https://github.com/mvysny/karibu-tools/blob/main/.github/workflows/gradle.yml |
@wimdeblauwe we are waiting for adoptium linux installers adoptium/installer#330 |
Both are in place by now. |
By choosing a less specific version, we can take advantage of the pre-installed JVMs as part of the Github runner's image, https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md#java. In that vein as well, "AdoptOpenJDK" is now "Adoptium" / "Temurin", and so to take advantage of cache we need to choose that. JDK 17 should be pre-installed as part of actions/runner-images#4085 See https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/ Follow up, deephaven#1513
By choosing a less specific version, we can take advantage of the pre-installed JVMs as part of the Github runner's image, https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md#java. In that vein as well, "AdoptOpenJDK" is now "Adoptium" / "Temurin", and so to take advantage of cache we need to choose that. JDK 17 should be pre-installed as part of actions/runner-images#4085 See https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/ Follow up, #1513
Any status updates on Linux? |
@tinolazreg still waiting for adoptium binaries adoptium/installer#330 |
This issue seems close to completion, I wonder when this will be complete. |
@Davio thanks for the update! We will get back to this soon |
@Davio we will postpone this as it is said
|
accept |
The Linux installer (the last one) has been merged, the images with the Eclipse Temurin 17 jdk will be deployed next week. |
Hi @mikhailkoliada , any ETA on when JDK 17 be available in the |
@martoncsukas the new image is currently being deployed. Some environments already have JDK17 the rest will have it tomorrow. |
It seems like most of the code is in place, but the README(s), such as https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-Readme.md still need to be amended. |
@Davio Ubuntu20.04 is not yet updated. Will be finished next week |
It seems like the scripts were already fixed though, is it just a matter of deployment now? |
@Davio correct |
It seems like the Ubuntu agents have been updated, thanks for all the hard work everyone. :) |
Yes, everything has been deployed, closing now. |
This pipeline should only be started after upstream release new runner templates[1] with Java 17 installed. [1]: actions/runner-images#4085 [skip ci]
Tool name
openjdk version "17"
Tool license
GPLv2+CE
Add or update?
Desired version
latest
Approximate size
No response
Brief description of tool
No response
URL for tool's homepage
No response
Provide a basic test case to validate the tool's functionality.
No response
Virtual environments affected
Can this tool be installed during the build?
No response
Tool installation time in runtime
No response
Are you willing to submit a PR?
No response
The text was updated successfully, but these errors were encountered: