You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
via table.proto/BatchTableRequest. The interesting part of this will likely be serializing TableDefinition into an appropriate grpc structure. I'm assuming we'd want to use the flight schema? (Is flight schema opaque bytes? If so, does it make sense for use to capture it in a more structured form?)
(EDIT) There was some mention of supporting creation of input tables implicitly via a doPut - but I'd like to make sure we have an explicit create accessible via BatchTableRequest. The creation via BatchTableRequest will not take any data, just a definition/schema.
Note: it would probably be good to have support for io.deephaven.db.v2.utils.KeyedArrayBackedMutableTable#make(io.deephaven.db.tables.TableDefinition, java.lang.String...) too, if it's not too much more work.
Off-topic(?): I've chatted with @nbauernfeind and I think that doPut's against existing input table tickets should trigger io.deephaven.db.util.config.MutableInputTable#add(Table newData)
This pull request is broken into three commits to start (with JS API client code to follow in a later pull request):
* ClassUtil improvements
* Proposed MutableInputTable api enhancements
* Proposed gRPC api and implementation
ClassUtil got its lookupClass from the dataobjects ClassUtil, but this implementation isn't thread safe, and while it supports both Class.getName() and Class.getCanonicalName() array notation, it only supports getName() inner type notation. Additionally, it initializes the class on first mention, which could mean for example that an arbitrary doPut could force the server to load a class, even if not serializable. This commit still supports (ignores) generic arguments provided to the class, but otherwise delegates to common-lang3 to actually find the class, and provide the class instance without initializing it.
The MutableInputTable changes are intended to make it easier to use from gRPC on the server, and removes some details where the DHE openapi was used to provide implementation details of the input table.
The gRPC API adds a createInputTable call in table service (still has some TODOs for discussion), and provides a separate gRPC service to interact with the input table itself.
Partial #1271
No description provided.
The text was updated successfully, but these errors were encountered: