Provide gRPC api for input tables #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
added
feature request
devinrsmith
requested changes
Oct 12, 2021
DB/src/main/java/io/deephaven/db/v2/utils/KeyedArrayBackedMutableTable.java
Show resolved
Hide resolved
proto/proto-backplane-grpc/src/main/proto/deephaven/proto/inputtable.proto
Outdated
Show resolved
Hide resolved
proto/proto-backplane-grpc/src/main/proto/deephaven/proto/table.proto
Outdated
Show resolved
Hide resolved
proto/proto-backplane-grpc/src/main/proto/deephaven/proto/table.proto
Outdated
Show resolved
Hide resolved
proto/proto-backplane-grpc/src/main/proto/deephaven/proto/inputtable.proto
Outdated
Show resolved
Hide resolved
grpc-api/src/main/java/io/deephaven/grpc_api/table/inputtables/InputTableServiceGrpcImpl.java
Show resolved
Hide resolved
grpc-api/src/main/java/io/deephaven/grpc_api/table/inputtables/InputTableServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
grpc-api/src/main/java/io/deephaven/grpc_api/table/ops/CreateInputTableGrpcImpl.java
Show resolved
Hide resolved
rcaudy
reviewed
Oct 13, 2021
rcaudy
reviewed
Oct 13, 2021
DB/src/main/java/io/deephaven/db/util/config/MutableInputTable.java
Outdated
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/v2/utils/KeyedArrayBackedMutableTable.java
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/v2/utils/KeyedArrayBackedMutableTable.java
Outdated
Show resolved
Hide resolved
niloc132
force-pushed
the
1271-input-tables
branch
from
36695a7
to
487a6e7
Compare
niloc132
force-pushed
the
1271-input-tables
branch
from
487a6e7
to
2b327af
Compare
nbauernfeind
previously approved these changes
Nov 5, 2021
devinrsmith
reviewed
Nov 5, 2021
Comment on lines
60
to
65
| Message message = Message.getRootAsMessage(request.getSchema().asReadOnlyByteBuffer()); | ||
| if (message.headerType() != MessageHeader.Schema) { | ||
| throw GrpcUtil.statusRuntimeException(Code.INVALID_ARGUMENT, | ||
| "Must specify schema header in schema message"); | ||
| } | ||
| tableDefinitionFromSchema = BarrageUtil.convertArrowSchema((Schema) message.header(new Schema())).tableDef; |
There was a problem hiding this comment.
Looks like from this context we don't have to worry about the magic 8 bytes?
I wonder if we should try to use the utility code, or generalize the utility code, in io.deephaven.grpc_api.util.SchemaHelper and/or BarrageUtil instead of doing it inline here?
There was a problem hiding this comment.
Added a new method to SchemaHelper to unwrap an arbitrary ByteBuffer, then pass to BarrageUtil to convert to the TableDefinition.
devinrsmith
previously approved these changes
Nov 5, 2021
nbauernfeind
previously approved these changes
Nov 5, 2021
niloc132
dismissed stale reviews from nbauernfeind and devinrsmith
via
3b109b0
devinrsmith
approved these changes
Nov 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is broken into three commits to start (with JS API client code to follow):
ClassUtil got its lookupClass from the dataobjects ClassUtil, but this implementation isn't thread safe, and while it supports both Class.getName() and Class.getCanonicalName() array notation, it only supports getName() inner type notation. Additionally, it initializes the class on first mention, which could mean for example that an arbitrary doPut could force the server to load a class, even if not serializable. This commit still supports (ignores) generic arguments provided to the class, but otherwise delegates to common-lang3 to actually find the class, and provide the class instance without initializing it.
The MutableInputTable changes are intended to make it easier to use from gRPC on the server, and removes some details where the DHE openapi was used to provide implementation details of the input table.
The gRPC API adds a createInputTable call in table service (still has some TODOs for discussion), and provides a separate gRPC service to interact with the input table itself.