-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Under Review pagination issues for big screens. #2581
fix: Under Review pagination issues for big screens. #2581
Conversation
Hi @victorgcramos . Thank you for your pull request. Your code is looing good for me. Also the addition e2e test case is great. I get the failling at |
Waiting for #2549. |
@vibros68 good catch, mate. Fixed! It's ready for another review. |
LGTM @victorgcramos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Needs final approval from @tiagoalvesdulce.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #2580
This diff fixes some pagination issues for inventories with the same tokens amount as the proposal page size, rendering for big screens. Also, adds e2e tests to cover these cases.