fix: Under Review pagination issues for big screens. #2581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorgcramos
changed the title
|
Hi @victorgcramos . Thank you for your pull request. Your code is looing good for me. Also the addition e2e test case is great. I get the failling at |
|
Waiting for #2549. |
|
@vibros68 good catch, mate. Fixed! It's ready for another review. |
|
LGTM @victorgcramos |
lukebp
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2580
This diff fixes some pagination issues for inventories with the same tokens amount as the proposal page size, rendering for big screens. Also, adds e2e tests to cover these cases.