Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Under Review tab pagination not working for 5 authorized proposals. #2580

Closed
victorgcramos opened this issue Sep 13, 2021 · 5 comments · Fixed by #2581
Closed

Under Review tab pagination not working for 5 authorized proposals. #2580

victorgcramos opened this issue Sep 13, 2021 · 5 comments · Fixed by #2581
Labels
bug A bug that made it into a production environment.

Comments

@victorgcramos
Copy link
Member

The current "Under Review" tab is not rendering the unauthorized proposals when there are 5 authorized on list for long height screens.

under-review-authorized

Here's the /inventory response:

{
    "vetted": {
        "approved": [
            "667e4c08f2ae7046"
        ],
        "authorized": [
            "f61053aefdb2cf5e",
            "fbc063ef51c0f715",
            "5864bfa2909a4851",
            "df5655878846ff10",
            "8e7f9d7e4f408613"
        ],
        "ineligible": [
            "faf00e553d58256e",
            "303644e68ed9c533",
            "1f47fdabda77ab3e",
            "d22a532f845a6026",
            "5f0f9f72259b702d",
            "b455beef30f45d2c",
            "28dd7465d2d00526",
            "44d1df1319ba6611",
            "5ee747e601df1e68"
        ],
        "unauthorized": [
            "238c041afdef512a",
            "5a7dafa92b303913",
            "45707323e959952c",
            "76468a996ab86274",
            "3a0a76ac44cc140a",
            "6ee627dc9afe9217",
            "94432aa6972ba625",
            "0281472674643862",
            "e917eee7d134f419",
            "e1c892aa37dd5f36",
            "784f8376f1faf33e",
            "793c1e9a1a3b1b1c",
            "a80c5d7072dff868",
            "ddbc3f20b7108f39",
            "22fd4f713e207204",
            "ac4e67b2101c2a1f",
            "dfd0fc00e441d650",
            "50c14c5caccd0327",
            "fdfea0e42ab0ac2a",
            "99996d60421fbf4e"
        ]
    },
    "bestblock": 766537
}
@victorgcramos
Copy link
Member Author

On it.

@lukebp lukebp added 91cfcc8 bug A bug that made it into a production environment. labels Sep 14, 2021
@lukebp
Copy link
Member

lukebp commented Sep 14, 2021

@victorgcramos what PR introduded this bug.

@victorgcramos
Copy link
Member Author

#2552 introduced it.

@lukebp
Copy link
Member

lukebp commented Sep 14, 2021

@vibros68 please review the PR fix for this bug.

@vibros68
Copy link
Contributor

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug that made it into a production environment.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants