Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tpw urn #87

Merged
merged 9 commits into from
Nov 12, 2021
Merged

Support tpw urn #87

merged 9 commits into from
Nov 12, 2021

Conversation

agusaldasoro
Copy link
Contributor

@agusaldasoro agusaldasoro commented Nov 9, 2021

Add support for third party collections

@agusaldasoro agusaldasoro marked this pull request as ready for review November 11, 2021 17:47
@agusaldasoro agusaldasoro requested a review from menduz November 11, 2021 17:48
Copy link
Member

@menduz menduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor thing in the tests. I'd add one for matic network to verify that we won't break the contracts removing the TPR from the list

contractAddress: "0xC6349360CF0143Bf54FDC376060532C044883b8C",
collectionId: "summerCollection",
itemId: "hat",
blockchain: "ethereum",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
blockchain: "ethereum",
blockchain: "ethereum",
thirdPartyName: "aThirdParty",

@agusaldasoro
Copy link
Contributor Author

I've added a test for matic third-party wearables, anyway it's commented as we currently don't have a contract for it.

@agusaldasoro agusaldasoro merged commit 1cfb0dd into main Nov 12, 2021
@agusaldasoro agusaldasoro deleted the support-tpw-urn branch November 12, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants