-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tpw urn #87
Support tpw urn #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a minor thing in the tests. I'd add one for matic
network to verify that we won't break the contracts removing the TPR from the list
contractAddress: "0xC6349360CF0143Bf54FDC376060532C044883b8C", | ||
collectionId: "summerCollection", | ||
itemId: "hat", | ||
blockchain: "ethereum", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blockchain: "ethereum", | |
blockchain: "ethereum", | |
thirdPartyName: "aThirdParty", |
I've added a test for matic third-party wearables, anyway it's commented as we currently don't have a contract for it. |
Add support for third party collections