Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for linked wearables urns #188

Merged
merged 11 commits into from
Jul 12, 2024
Merged

feat: support for linked wearables urns #188

merged 11 commits into from
Jul 12, 2024

Conversation

marianogoldman
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 19, 2024 •
edited
Loading

Test this pull request

  • The package can be tested by running 
    yarn upgrade "https://sdk-team-cdn.decentraland.org/@dcl/urn-resolver/branch/linked-wearables/dcl-urn-resolver-3.4.1-9750345904.commit-3d8f65d.tgz"

LautaroPetaccio
LautaroPetaccio reviewed Jun 20, 2024
View reviewed changes
src/resolvers.ts Outdated Show resolved Hide resolved
src/resolvers.ts Outdated Show resolved Hide resolved
aleortega
aleortega approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@aleortega aleortega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with nits:

  • cases miss-match
  • remove old test

src/resolvers.ts Outdated Show resolved Hide resolved
test/parse-urn.spec.ts Outdated Show resolved Hide resolved
@marianogoldman marianogoldman marked this pull request as ready for review July 12, 2024 14:14
@marianogoldman marianogoldman merged commit 13d84e2 into main Jul 12, 2024
3 checks passed
@marianogoldman marianogoldman deleted the linked-wearables branch July 12, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LautaroPetaccio LautaroPetaccio LautaroPetaccio left review comments

@aleortega aleortega aleortega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marianogoldman @LautaroPetaccio @aleortega