Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extended URNs for dcl wearables / emotes #168

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

Julieta11
Copy link
Contributor

@Julieta11 Julieta11 commented Jul 24, 2023

This PR adds URN resolvers to ensure the unique identification of each minted emote / wearable item by extending their URNs to include the tokenId property as the last part

@Julieta11 Julieta11 self-assigned this Jul 24, 2023
@Julieta11 Julieta11 changed the title [WIP] feat: extended URNs for dcl wearables feat: extended URNs for dcl wearables / emotes Jul 28, 2023
@aleortega aleortega force-pushed the feat/token-id-resolvers branch from 38b69c6 to a7f5649 Compare July 31, 2023 14:32
@github-actions
Copy link

github-actions bot commented Jul 31, 2023

Test this pull request

  • The package can be tested by running
    yarn upgrade "https://sdk-team-cdn.decentraland.org/@dcl/urn-resolver/branch/feat/token-id-resolvers/dcl-urn-resolver-2.2.1-5833960577.commit-db534b6.tgz"

@aleortega aleortega force-pushed the feat/token-id-resolvers branch 5 times, most recently from d387606 to 35e0929 Compare August 11, 2023 12:45
@aleortega aleortega force-pushed the feat/token-id-resolvers branch from 35e0929 to 8d08835 Compare August 11, 2023 12:47
@aleortega aleortega marked this pull request as ready for review August 11, 2023 12:47
@aleortega aleortega force-pushed the feat/token-id-resolvers branch from 86eb0fc to a71a1c3 Compare August 11, 2023 14:49
@aleortega aleortega force-pushed the feat/token-id-resolvers branch from a71a1c3 to b94ddc1 Compare August 11, 2023 14:50
@aleortega aleortega merged commit 2a38e9d into main Aug 11, 2023
@aleortega aleortega deleted the feat/token-id-resolvers branch August 11, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants