Add parser for third party collections #118
Conversation
| @@ -115,7 +115,7 @@ export type BlockchainCollectionV2Asset = BaseBlockchainAsset & { | |||
| /** | |||
| * @public | |||
| */ | |||
| export type BlockchainCollectionThirdParty = BaseBlockchainAsset & { | |||
| export type BlockchainCollectionThirdPartyItem = BaseBlockchainAsset & { | |||
| namespace: 'decentraland' | |||
| type: "blockchain-collection-third-party" | |||
There was a problem hiding this comment.
id should be different for third party collection and third party collection item
There was a problem hiding this comment.
That's something that I wasn't sure about, anyway, should I make a breaking change for the items? Or how should I name the collection itself? 🤔
There was a problem hiding this comment.
To be consistent with the others collection, i think it should be BlockchainCollectionThirdParty for the collection and BlockchainCollectionThirdPartyAsset for the items.
There was a problem hiding this comment.
I thought the same, but doing that will imply a breaking change: BlockchainCollectionThirdParty -> BlockchainCollectionThirdPartyAsset and we want to avoid that
test/urn.spec.ts
Outdated
| blockchain: "ethereum", | ||
| thirdPartyName: "aThirdParty", | ||
| network: "mumbai", | ||
| type: "blockchain-collection-third-party" |
There was a problem hiding this comment.
type should be different for third party collection and third party collection item
src/resolvers.ts
Outdated
| @@ -263,7 +266,7 @@ export async function resolveCollectionV2( | |||
| } | |||
| } | |||
|
|
|||
| export async function resolveThirdPartyCollection( | |||
| export async function resolveThirdPartyCollectionItem( | |||
No description provided.