Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov reporting to build process. #614

Merged
merged 1 commit into from
Sep 25, 2017

Conversation

dopry
Copy link
Contributor

@dopry dopry commented Sep 16, 2017

- Summary
depends on: #610
closes: #609

This PR will add codecov reporting to the build process.

For this to properly work someone will need to

  1. goto https://codecov.io/gh/netlify/netlify-cms/settings and authorize codecov
  2. copy the repository upload token.
  3. goto https://travis-ci.org/netlify/netlify-cms/settings
  4. add an environment variable named CODECOV_TOKEN with the value of the repository upload token.

- Test plan

Do the above and then merge. The following master build should update the baseline info in codecov. In my experience it takes a few PRs and builds for codecov to start reporting properly.

- Description for the changelog

Add codecov reporting to the build process.

@medfreeman
Copy link

I think you only need to perform step 1, as uploading to codecov auth is automatically handled for travis without needing to provide a token (it's said on codecov but not so clear).

@erquhart
Copy link
Contributor

LGTM, but withholding approval until #610 is merged.

@erquhart
Copy link
Contributor

erquhart commented Sep 21, 2017

Authorized codecov and restarted the CI build.

Copy link
Contributor

@Benaiah Benaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's useful, though I'd like to give it a bit of time before we make an hard requirements on PRs based on its output.

@erquhart erquhart merged commit aa14a66 into decaporg:master Sep 25, 2017
@erquhart
Copy link
Contributor

@Benaiah agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add code coverage
4 participants