Add code coverage output generation to npm test #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopry
force-pushed
the
609_jest_code_coverage
branch
3 times, most recently
from
44fa8a9
to
cc0092a
Compare
|
applies to #609 |
dopry
force-pushed
the
609_jest_code_coverage
branch
2 times, most recently
from
aefdb41
to
606b23a
Compare
erquhart
reviewed
Sep 19, 2017
| @@ -97,7 +97,9 @@ export default function remarkPaddedLinks() { | |||
| * nesting. If `end` is truthy, get the last node, otherwise first. | |||
| */ | |||
| function getEdgeTextChild(node, end) { | |||
| const findFn = end ? findLast : find; | |||
| let findFn; | |||
There was a problem hiding this comment.
This really bothers me. I commented here to see if we can get some clarity: istanbuljs/babel-plugin-istanbul#95.
There was a problem hiding this comment.
For now just add a comment explaining why it's written this way.
…on assignment.
.\node_modules\.bin\jest --coverage --coverageReporters lcov
was triggering t the error
\src\components\Widgets\Markdown\serializers\remarkPaddedLinks.js:100
var findFn = /* istanbul ignore next */(cov_1gwlaxh2sq.s[21]++, end ? /* istanbul ignore next */() : /* istanbul ignore next */());
^
SyntaxError: Unexpected token )
dopry
force-pushed
the
609_jest_code_coverage
branch
from
606b23a
to
a73c798
Compare
|
commented and rebased. |
|
@Benaiah @tech4him1 feel free to merge when one of you approves. |
Benaiah
approved these changes
Sep 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
This is a first step towards adding support for a 3rd party code coverage service. It adds code coverage output to the npm test command.
- Test plan
on your command line run
verify you see the code coverage output as a result of the test.
verify the coverage folder is generated with the lconv output.
verify the coverage folder is ignored by git.
- Description for the changelog
Add code coverage to
npm test- A picture of a cute animal (not mandatory but encouraged)