Fix for flake8 triggering for removed files #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that is accomplished by using --diff-filter parameter in git diff (taken from http://stackoverflow.com/questions/6879501/filter-git-diff-by-type-of-change) also this commit changes the log level from error to info when particular VCS is not found
| @@ -129,7 +129,7 @@ def get_vcs(self): | |||
| try: | |||
| vcs = vcs(self.commits, self.options) | |||
| except VCSNotInstalledError: | |||
| logger.error('Seems like {0} is not installed'.format(vcs.name)) | |||
| logger.info('Seems like {0} is not installed'.format(vcs.name)) | |||
There was a problem hiding this comment.
this now will only print in console when verbose flag is used. otherwise it silently fails and proceeds to check other VCS. if none are found, then it flake8-diff will exit with error
added 4 commits
July 26, 2015 11:34
that seemed appropriate considering package name
| @@ -1,3 +1,7 @@ | |||
| __version__ = '0.2.0' | |||
| __description__ = ( | |||
There was a problem hiding this comment.
moved short description here so that it can be reused both by setup.py and in main.py
|
@gregarmer removed the description from the |
gregarmer
added a commit
that referenced
this pull request
Aug 4, 2015
Fix for flake8 triggering for removed files
|
v0.2.2 is up - https://pypi.python.org/pypi/flake8-diff |
|
awesome. thanks @gregarmer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #29
that is accomplished by using --diff-filter parameter in git diff (taken from http://stackoverflow.com/questions/6879501/filter-git-diff-by-type-of-change)
also this commit changes the log level from error to info when particular VCS is not found
also:
--versionparameter