Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flake8 triggers for deleted files #29

Closed
miki725 opened this issue Jul 26, 2015 · 0 comments · Fixed by #30
Closed

flake8 triggers for deleted files #29

miki725 opened this issue Jul 26, 2015 · 0 comments · Fixed by #30

Comments

@miki725
Copy link
Contributor

miki725 commented Jul 26, 2015 

Found violations: hello.py
    E902 @ 1:1 - FileNotFoundError: [Errno 2] No such file or directory: 'hello.py'

Obviously above error is silly since file is removed so flake8 should not be triggered.
miki725 pushed a commit to miki725/flake8-diff that referenced this issue Jul 26, 2015
fix for dealertrack#29 which does not trigger flake8 for removed files
25df445 
that is accomplished by using --diff-filter parameter in git diff (taken from http://stackoverflow.com/questions/6879501/filter-git-diff-by-type-of-change)

also this commit changes the log level from error to info when particular VCS is not found
@miki725 miki725 mentioned this issue Jul 26, 2015
Merged
miki725 pushed a commit to miki725/flake8-diff that referenced this issue Jul 26, 2015
fix for dealertrack#29 which does not trigger flake8 for removed files
990236d 
that is accomplished by using --diff-filter parameter in git diff (taken from http://stackoverflow.com/questions/6879501/filter-git-diff-by-type-of-change)

also this commit changes the log level from error to info when particular VCS is not found
miki725 pushed a commit to miki725/flake8-diff that referenced this issue Aug 3, 2015
bumped version to 0.1.2 which addresses dealertrack#29
bec0439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for flake8 triggering for removed files miki725/flake8-diff
1 participant
@miki725