Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn_error_options docs #2691

Merged
merged 6 commits into from
Jan 12, 2023
Merged

warn_error_options docs #2691

merged 6 commits into from
Jan 12, 2023

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Jan 10, 2023 •
edited
Loading

What are you changing in this pull request and why?

fixes: #2687

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@netlify
Copy link

netlify bot commented Jan 10, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 124a150
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/63c0332c3b92c40008ecd5e5
😎 Deploy Preview https://deploy-preview-2691--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Jan 10, 2023
@jtcohen6 jtcohen6 linked an issue Jan 10, 2023 that may be closed by this pull request
New global config: --warn-error-options #2687
Closed
1 task
jtcohen6
jtcohen6 reviewed Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the initiative on this! I'm happy to pick this up & take over the finish line if you'd rather hand it off - jlmk

Once the v1.4 migration guide is initialized (#2646), we'll also want a note in there linking back to this update. I can hit that in a follow-up PR, to avoid lots of merge conflicts.

website/docs/reference/global-configs.md Outdated Show resolved Hide resolved
website/docs/reference/profiles.yml.md Outdated Show resolved Hide resolved
website/docs/reference/global-configs.md Outdated Show resolved Hide resolved
website/docs/reference/global-configs.md Outdated Show resolved Hide resolved
website/docs/reference/global-configs.md Outdated Show resolved Hide resolved
@MichelleArk MichelleArk mentioned this pull request Jan 10, 2023
Merged
6 tasks
@MichelleArk MichelleArk marked this pull request as ready for review January 11, 2023 02:38
@MichelleArk MichelleArk requested a review from a team as a code owner January 11, 2023 02:38
jtcohen6
jtcohen6 previously approved these changes Jan 11, 2023
View reviewed changes
Copy link
Collaborator

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you nailed it!

@jtcohen6 jtcohen6 added the dbt-core v1.4 Docs impact for the v1.4 release (Jan 2023) label Jan 11, 2023
@MichelleArk MichelleArk merged commit 15d3ab0 into current Jan 12, 2023
@MichelleArk MichelleArk deleted the warn-error-options branch January 12, 2023 16:24
@moltar moltar mentioned this pull request Jun 28, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content dbt-core v1.4 Docs impact for the v1.4 release (Jan 2023) size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New global config: --warn-error-options
2 participants
@MichelleArk @jtcohen6