Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

176 clean before deps #183

Merged
merged 3 commits into from
Sep 30, 2023
Merged

176 clean before deps #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
656b5bb
Run clean in case old packages were removed
b-per Sep 29, 2023
60442b7
Prevent VSCode config from being added to git
b-per Sep 29, 2023
a6b792f
Fix typo
b-per Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ venv/
__pycache__/
# IDEs
.idea/
.vscode/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm genuinely surprised we've managed to get this far without adding .vscode to the gitignore. Thanks for adding it here.


**/database.db
logs/
Expand Down
3 changes: 2 additions & 1 deletion dbt_meshify/dbt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ def invoke(
result = self.dbt_runner.invoke(runner_args if runner_args else [])
if not result.success and result.exception:
if isinstance(result.exception, UninstalledPackagesFoundError):
logger.debug("Project missing packages, running dbt deps...")
logger.debug("Project missing packages, running dbt clean and dbt deps...")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos for updating the debug log.

self.dbt_runner.invoke(["clean"])
self.dbt_runner.invoke(["deps"])
result = self.dbt_runner.invoke(runner_args if runner_args else [])

Expand Down