176 clean before deps #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasyager
approved these changes
Sep 30, 2023
| @@ -7,6 +7,7 @@ venv/ | |||
| __pycache__/ | |||
| # IDEs | |||
| .idea/ | |||
| .vscode/ | |||
There was a problem hiding this comment.
I'm genuinely surprised we've managed to get this far without adding .vscode to the gitignore. Thanks for adding it here.
| @@ -22,7 +22,8 @@ def invoke( | |||
| result = self.dbt_runner.invoke(runner_args if runner_args else []) | |||
| if not result.success and result.exception: | |||
| if isinstance(result.exception, UninstalledPackagesFoundError): | |||
| logger.debug("Project missing packages, running dbt deps...") | |||
| logger.debug("Project missing packages, running dbt clean and dbt deps...") | |||
There was a problem hiding this comment.
Kudos for updating the debug log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176
Runs
dbt cleanbeforedbt depswhen the packages installed don't match the packages inpackages.ymlOne of the use cases where clean is required for example is when people used to use
dbt_metricsand then move to 1.6. Removing the package frompackages.ymldoesn't remove it fromdbt_packagesand still raise compilation errors.