Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.4.latest] convert 062_defer_state_tests #6657

Merged
merged 2 commits into from
Jan 19, 2023
Merged

[Backport 1.4.latest] convert 062_defer_state_tests #6657

merged 2 commits into from
Jan 19, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Backport 07a004b from #6616.

@jtcohen6 @github-actions
convert 062_defer_state_tests (#6616)
95176d1 
* Fix --favor-state flag

* Convert 062_defer_state_tests

* Revert "Fix --favor-state flag"

This reverts commit ccbdcba.

* Reformat

* Revert "Revert "Fix --favor-state flag""

This reverts commit fa9d2a0.

(cherry picked from commit 07a004b)
@github-actions github-actions bot requested a review from a team January 19, 2023 10:00
@github-actions github-actions bot requested a review from a team as a code owner January 19, 2023 10:00
@cla-bot cla-bot bot added the cla:yes label Jan 19, 2023
@github-actions
Copy link
Contributor Author

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@jtcohen6
Copy link
Contributor

jtcohen6 commented Jan 19, 2023 •
edited
Loading

I excluded the changelog entry from #6616 because:

  • it started as a test conversion
  • the actual fix is being backported for inclusion in v1.4.0rc2 → v1.4.0 (final), so we don't need to include it again in v1.5.0

Adding it here!

@jtcohen6 jtcohen6 merged commit f73359b into 1.4.latest Jan 19, 2023
@jtcohen6 jtcohen6 deleted the backport-6616-to-1.4.latest branch January 19, 2023 12:27
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 approved these changes

@aranke aranke Awaiting requested review from aranke

@McKnight-42 McKnight-42 Awaiting requested review from McKnight-42 McKnight-42 was automatically assigned from dbt-labs/core-group

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jtcohen6