-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert 062_defer_state_tests #6616
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2023
McKnight-42
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Favor state isn't a config i've heard of so will look into that a bit more, but the tests themselves all make sense and I don't see any logical issues
jtcohen6
force-pushed
the
jerco/convert-defer-state-tests
branch
from
January 19, 2023 08:41
103c036
to
45e64d0
Compare
This reverts commit fa9d2a0.
jtcohen6
added a commit
that referenced
this pull request
Jan 19, 2023
* convert 062_defer_state_tests (#6616) * Fix --favor-state flag * Convert 062_defer_state_tests * Revert "Fix --favor-state flag" This reverts commit ccbdcba. * Reformat * Revert "Revert "Fix --favor-state flag"" This reverts commit fa9d2a0. (cherry picked from commit 07a004b) * Add changelog entry Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6613
resolves #6617
Backport to
1.4.latest
after merging (see #6617 (comment))Description
pytest
frameworkwrite_file
,rm_file
). I was a bit inconsistent in terms of what I defined in + imported fromfixtures.py
, and what I just kept as strings defined inline.--favor-state
that's currently included in v1.4.0-rc1 (feature/favor-state-node #5859).I'll open a separate issue + PR to include that commit.We should backport this PR to1.4.latest
, and include the fix for v1.4.0-rc2.tests/functional
rather thantests/adapter
, and I'll open follow-up PRs in adapter repos to remove this test entirely.Adapter PRs
Checklist
I have runchangie new
to create a changelog entry