Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify error log for number of allowed models in a Python file #6251

Merged
merged 3 commits into from
Dec 1, 2022
Merged

clarify error log for number of allowed models in a Python file #6251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af16d3b
:art: update dbt python model logging error
justbldwn Nov 15, 2022
07ad378
:memo: updating changelog via changie new
justbldwn Nov 15, 2022
c81c538
Merge branch 'dbt-labs:main' into fix_python_model_logs
justbldwn Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/unreleased/Fixes-20221115-081021.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
kind: Fixes
body: Clarify Error Message for how many models are allowed in a Python file
time: 2022-11-15T08:10:21.527884-05:00
custom:
Author: justbldwn
Issue: "6245"
PR: "6251"
6 changes: 5 additions & 1 deletion core/dbt/parser/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,11 @@ def visit_FunctionDef(self, node: ast.FunctionDef) -> None:

def check_error(self, node):
if self.num_model_def != 1:
raise ParsingException("dbt only allow one model defined per python file", node=node)
raise ParsingException(
f"dbt allows exactly one model defined per python file, found {self.num_model_def}",
node=node,
)

if len(self.dbt_errors) != 0:
raise ParsingException("\n".join(self.dbt_errors), node=node)

Expand Down