Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify error log for number of allowed models in a Python file #6251

Merged
merged 3 commits into from
Dec 1, 2022

Conversation

justbldwn
Copy link
Contributor

@justbldwn justbldwn commented Nov 15, 2022

resolves #6245

Description

simple fix to update the logging when less than or more than one python models are found in a given python file

Checklist

@cla-bot cla-bot bot added the cla:yes label Nov 15, 2022
@justbldwn justbldwn marked this pull request as ready for review November 15, 2022 13:11
@justbldwn justbldwn requested review from a team as code owners November 15, 2022 13:11
@justbldwn justbldwn requested review from gshank and sgrebnov November 15, 2022 13:11
@jtcohen6 jtcohen6 added Team:Language ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering labels Nov 17, 2022
@gshank
Copy link
Contributor

gshank commented Nov 30, 2022

Could you merge main into your branch? I think the test error is something that was updated in main.

@justbldwn
Copy link
Contributor Author

Could you merge main into your branch? I think the test error is something that was updated in main.

sure thing! just did now, i think it will require another approval for the CI to run. thanks for taking a look @gshank

@gshank
Copy link
Contributor

gshank commented Nov 30, 2022

There's a strange error in the CI jobs now; I'm looking into it.

@justbldwn
Copy link
Contributor Author

There's a strange error in the CI jobs now; I'm looking into it.

thank you! let me know if there is anything else I can help you with on this, happy to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1501] Clarify Error Message for how many models are allowed in a Python file
3 participants