Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ALLOW_UNUSED_CONFIG_PATHS flag #6091

Closed
wants to merge 2 commits into from
Closed

Add ALLOW_UNUSED_CONFIG_PATHS flag #6091

wants to merge 2 commits into from

Conversation

katieclaiborne
Copy link

@katieclaiborne katieclaiborne commented Oct 17, 2022

resolves #6080

Description

Added a new ALLOW_UNUSED_CONFIG_PATHS flag, which can be used to raise an error when unused config paths are present.

Checklist

@katieclaiborne katieclaiborne requested a review from a team October 17, 2022 21:56
@katieclaiborne katieclaiborne requested review from a team as code owners October 17, 2022 21:56
@cla-bot
Copy link

cla-bot bot commented Oct 17, 2022

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @katieclaiborne

@emmyoop emmyoop added the Hackathon Coalesce Hackathon Submissions label Oct 17, 2022
@katieclaiborne
Copy link
Author

cc @felippecaso

@cla-bot cla-bot bot added the cla:yes label Oct 17, 2022
@katieclaiborne katieclaiborne changed the title changes from hackathon Add ALLOW_UNUSED_CONFIG_PATHS flag Oct 18, 2022
@jtcohen6
Copy link
Contributor

Awesome work @katieclaiborne, and thanks for the contribution!

This prompted some solid conversation from the team about what a good general-purpose approach here could look like. I'm going to close this PR and the accompanying issue in favor of a new proposal. More context in #6080 (comment)

@jtcohen6 jtcohen6 closed this Oct 27, 2022
@katieclaiborne katieclaiborne deleted the add-flag-unused-resource-configs branch October 27, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Hackathon Coalesce Hackathon Submissions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1359] [Feature] Create option to raise severity of unused configuration path warning
3 participants