Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1359] [Feature] Create option to raise severity of unused configuration path warning #6080

Closed
3 tasks done
katieclaiborne opened this issue Oct 17, 2022 · 2 comments
Closed
3 tasks done
Labels
enhancement New feature or request Hackathon Coalesce Hackathon Submissions

Comments

@katieclaiborne
Copy link

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

I would like to be able to configure this warning as an error, so that we catch misspellings before they're merged.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

Yes!

Anything else?

No response

@katieclaiborne katieclaiborne added enhancement New feature or request triage labels Oct 17, 2022
@github-actions github-actions bot changed the title [Feature] Create option to raise severity of unused configuration path warning [CT-1359] [Feature] Create option to raise severity of unused configuration path warning Oct 17, 2022
@leahwicz leahwicz added Hackathon Coalesce Hackathon Submissions and removed triage labels Oct 17, 2022
@jtcohen6 jtcohen6 self-assigned this Oct 27, 2022
@jtcohen6
Copy link
Contributor

Thanks for opening the issue @katieclaiborne, and for the awesome work in the hackathon!

We had a good conversation about this as a team earlier today. We'd like to solve this with something more general-purpose, whereby we provide users with more granular control over the --warn-error configuration. Today, it's a simple boolean ("all or nothing") switch to flip. We should also support users passing in the specific warning/exception classes that they want to treat as exceptions, rather than warnings. That way, we don't need a standalone config for every single warning/exception class.

I'll open a new issue to reflect that work.

@jtcohen6 jtcohen6 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2022
@katieclaiborne
Copy link
Author

Thanks, Jeremy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hackathon Coalesce Hackathon Submissions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants