-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pyproject toml builds dbt #6047
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @davidbloss |
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @davidbloss |
Hi @davidbloss! Thanks so much for opening this contribution up! We currently are a couple weeks away from scheduling work to revamp our package and release process for |
Hi @leahwicz, I understand and please take your time! |
I hadn't seen this a month ago — very cool! Does it simplify/unblock this work for us to first move We have been building our Docker images from specific release branches, rather than from the dist wheels built from those release branches. It does seem feasible that we could always build a wheel first. Not sure how tricky this is in practice / for our release process. |
Hey all, I am closing this since Poetry is IMO not the best path forward. Instead I will be reopening a similar branch that makes use of hatch - much better for CI and testing purposes |
resolves #5696 and #4674 and #4446
Description
This update to
pyproject.toml
allows pip to install dbt-core withpoetry
in place ofsetuptools
. dbt adapters, other dependent codebases, core devs, and users should not notice any changes from this update.Notes
setup.py
andMANIFEST.in
still remain but all their logic has been consolidated into pyproject.tomlpoetry.lock
provides a deterministic, version controlled option for dependency managementMapping old keys to new keys
python = "<version>"
under[tool.poetry.dependencies]
in place ofif sys.version_info ...
in setup.pyDropped entries
test_suite="test"
see deprecated setuptools featurezip_safe=False
see other deprecated setuptools featureAdded entries
license = "Apache-2.0"
homepage = "https://getdbt.com"
documentation = "https://docs.getdbt.com/"
Various links in
[tool.poetry.urls]
Checklist
changie new
to create a changelog entry