Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-160] Create/use pyproject.toml #4674

Closed
1 task done
iknox-fa opened this issue Feb 3, 2022 · 7 comments
Closed
1 task done

[CT-160] Create/use pyproject.toml #4674

iknox-fa opened this issue Feb 3, 2022 · 7 comments
Labels
enhancement New feature or request install release Release processes for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@iknox-fa
Copy link
Contributor

iknox-fa commented Feb 3, 2022

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

Given that:

  • We should move to using PEP-518 compliant build tool specification
  • People might like to use Poetry while developing dbt
  • SetupTools is .... not great.

We should consider utilizing a pyproject.toml file to enable all of those.

Describe alternatives you've considered

There aren't any that I've discovered

Who will this benefit?

Devs across the board

Are you interested in contributing this feature?

No response

Anything else?

No response

@iknox-fa iknox-fa added enhancement New feature or request triage labels Feb 3, 2022
@github-actions github-actions bot changed the title Create/use pyproject.toml [CT-160] Create/use pyproject.toml Feb 3, 2022
@jtcohen6 jtcohen6 added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality and removed triage labels Feb 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Aug 4, 2022
@github-actions
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest; add a comment to notify the maintainers.

@lostmygithubaccount lostmygithubaccount removed the stale Issues that have gone stale label Aug 12, 2022
@jtcohen6
Copy link
Contributor

@lostmygithubaccount Agree - we should still do this! In dbt-core and our adapter repos, too

@leahwicz
Copy link
Contributor

Let's get an estimation for this work for just dbt-core to start

@jtcohen6 jtcohen6 added install release Release processes for dbt-core + adapter plugins labels Aug 18, 2022
@iknox-fa
Copy link
Contributor Author

Skipped pointing on 9/22/22 BLG-- Spike needed to determine:

  • Will this break docker builds for cloud?
  • Are we doing things in setup.py that can't be done with pyproject.toml?

@iknox-fa
Copy link
Contributor Author

Spike still needed. BLG 9/12/22

@iknox-fa
Copy link
Contributor Author

iknox-fa commented Oct 5, 2022

Closing as duplicate of #5696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request install release Release processes for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

No branches or pull requests

4 participants