Minor fixes: UB in compute_block_grid_mapping(), tests for iterations.json, compilation #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th P-err, p-err, D-err) Errors may differ as they approach zero, leading to false positive test fails.
- #include<flint/nmod_vec.h> instead of <flint/nmod.h> for FLINT 2.8.4 and earlier - Remove some unused includes
- Add -D_GNU_SOURCE=1 to CXXFLAGS - Update library versions and paths - Add note about Python 2 or 3 failing on different machines
…mall.
We had to set the small value limit to 2^{-diff_precision/2}, otherwise tests from skydiving-master branch fail.
…64 (probably due to AVX instructions)
Fixes ./waf configure in Docker for new FLINT image
…ompute_block_grid_mapping error) The code was comparing iterators for different containers, which leads to undefined behaviour. In the specific case where the exception was observed (on a specific machine), available_block_maps[1].begin() == available_block_maps[0].end() returned true, unexpectedly. We fix it by using std::optional<iterator> and checking for null explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated FLINT image, added workaround to documentation
D-err,P-err,p-errandR-erronly if they are not too close to zero../waf configurefail on CircleCI due to missingmpfrandcblasdependencies.waf-tools/boost.pyPython2 compatible