Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flint version and missing nmod.h #234

Closed
bharathr98 opened this issue Apr 24, 2024 · 1 comment · Fixed by #237
Closed

Flint version and missing nmod.h #234

bharathr98 opened this issue Apr 24, 2024 · 1 comment · Fixed by #237
Labels
Milestone

Comments

@bharathr98
Copy link
Contributor

In the recent change where FLINT and BLAS were added as dependencies, there is a use of nmod.h from FLINT in ⬇️

Most older versions of FLINT do not have this header. Instead, the header was originally nmod_vec.h, which was later split into nmod.h and nmod_vec.h. This change was introduced in v2.8.5 (presumably, not explicitly mentioned in the changelog, but it can be seen in the PR flintlib/flint#1041)

The simplest fix would be to document this in the Install.md file. However I would personally request a different solution, since the UniGE cluster only has v2.7.1 available.

@vasdommes
Copy link
Collaborator

vasdommes commented Apr 24, 2024

Will the following work with FLINT 2.7.1 on your cluster?

#if __FLINT_RELEASE >= 20805
#include <flint/nmod.h>
#else
#include <flint/nmod_vec.h>
#endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants