Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0.0 June 5th SNAPSHOT] SwipeRefresh is below the first expanded Sticky Header #104

Closed
bornest opened this issue Jun 6, 2016 · 2 comments

Comments

@bornest
Copy link

bornest commented Jun 6, 2016

Hi! Thank you very much for the latest fixes, library has really improved in its usability!

Found a minor issue with the SwipeRefresh and Sticky Headers:

If the first Sticky Header in the list is expanded,
when you initiate refresh with SwipeRefresh,
SwipeRefresh animation is displayed below this header.

@davideas
Copy link
Owner

davideas commented Jun 6, 2016

Hi @bornest, @mdtuyen already reported this issue (see #83).
I also reported in the release note of last Snapshot.

Actually this is a strange bug: it's caused by the layout position order and I resolved it, but I've discovered yesterday that moving the StickyHeader layout inside the SwipeRefreshLayout it is not possible anymore to drag items: SwipeRefresh circle is showing while dragging down.
I've added more comments in the xml showing this fact.

I don't know how to resolve it having dragging feature working as well. You can test it in the demo app by commenting/un-commenting the lines in the layout fragment_recycler_view.xml

Maybe, a solution could be to disable sticky header while dragging.

@bornest
Copy link
Author

bornest commented Jun 6, 2016

OK, got it, thanks. Fortunately, I don't need dragging functionality right now.

Actually, maybe you could disable SwipeRefresh when entering the dragging mode,
and enabling it after you've finished dragging.

I guess you'd have to disable something in any case, 'cos it's a conflict of two use-case scenarios for one physical action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants