Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docker setup #81

Merged
merged 3 commits into from
Feb 25, 2019
Merged

Improve docker setup #81

merged 3 commits into from
Feb 25, 2019

Commits on Feb 24, 2019

  1. Use debian instead of alpine 

    This is related to issues with iconv on alpine linux (see [1]). I
noticed that the content file `tipuesearch_content.json` didn't contain
the sanitized text, but only the boolean `false`. I tracked it down to
the `iconv` call. After migration to the debian docker image it is
working fine. Build was started using `docker run --rm -it -w /build -v
"$PWD":/build daux/daux.io daux generate`.

[1] docker-library/php#428
    @gfrey
    gfrey committed Feb 24, 2019
    Configuration menu
    Copy the full SHA
    3e7f511 View commit details
    Browse the repository at this point in the history

  2. Optimize Dockerfile 

    This change will only copy the `compose.{json|lock}` files prior to
installing the dependencies. This improves container image build time
when only code changed, as it facilitates image caching.
    @gfrey
    gfrey committed Feb 24, 2019
    Configuration menu
    Copy the full SHA
    e4487d8 View commit details
    Browse the repository at this point in the history

  3. Fix file permissions 

    Using the user's uid and gid in the container prevents the output files
to belong to root.
    @gfrey
    gfrey committed Feb 24, 2019
    Configuration menu
    Copy the full SHA
    a689b9d View commit details
    Browse the repository at this point in the history