Improve docker setup #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to issues with iconv on alpine linux (see [1]). I noticed that the content file `tipuesearch_content.json` didn't contain the sanitized text, but only the boolean `false`. I tracked it down to the `iconv` call. After migration to the debian docker image it is working fine. Build was started using `docker run --rm -it -w /build -v "$PWD":/build daux/daux.io daux generate`. [1] docker-library/php#428
This change will only copy the `compose.{json|lock}` files prior to
installing the dependencies. This improves container image build time
when only code changed, as it facilitates image caching.
Using the user's uid and gid in the container prevents the output files to belong to root.
|
Hello, Funny because the move to alpine was a recommendation in #5 |
|
Thanks for maintaining the project! I didn't hesitate to change the base image under the assumption, that the docker container is mostly used to confine the PHP setup and easily generate the static pages. If people use the container to generate pages on the fly on the internet, this choice might be a bad one. |
|
You’re welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three fixes to the docker setup: