Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(domains): UI for Asset Domains (p2) #3995

Merged
merged 67 commits into from
Jan 28, 2022

Conversation

jjoyce0510
Copy link
Collaborator

Summary

This PR introduces the UI for Managing Domains. Note that managing Domains requires the Platform Privileges 'Manage Domains'.

Part 2 of #3953.

Screenshots

Screen Shot 2022-01-27 at 1 22 12 PM

Screen Shot 2022-01-27 at 1 22 18 PM

Screen Shot 2022-01-27 at 1 22 22 PM

Screen Shot 2022-01-27 at 1 22 32 PM

Screen Shot 2022-01-27 at 1 23 23 PM

Screen Shot 2022-01-27 at 1 23 54 PM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Jan 27, 2022

Unit Test Results (build & test)

  66 files  ±0    66 suites  ±0   15m 59s ⏱️ + 1m 31s
581 tests ±0  522 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit a44e493. ± Comparison against base commit 282851e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 27, 2022

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   36m 37s ⏱️ - 2m 51s
   275 tests +1     274 ✔️ +  1    0 💤 ±0  1 ±0 
1 266 runs  +7  1 235 ✔️ +11  30 💤  - 4  1 ±0 

For more details on these failures, see this check.

Results for commit a44e493. ± Comparison against base commit 282851e.

♻️ This comment has been updated with latest results.

@shirshanka shirshanka merged commit 27c543a into datahub-project:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants