-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(domains): UI for Asset Domains (p2) #3995
Merged
shirshanka
merged 67 commits into
datahub-project:master
from
jjoyce0510:data-domains-react
Jan 28, 2022
Merged
feat(domains): UI for Asset Domains (p2) #3995
shirshanka
merged 67 commits into
datahub-project:master
from
jjoyce0510:data-domains-react
Jan 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results (metadata ingestion) 5 files ±0 5 suites ±0 36m 37s ⏱️ - 2m 51s For more details on these failures, see this check. Results for commit a44e493. ± Comparison against base commit 282851e. ♻️ This comment has been updated with latest results. |
shirshanka
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the UI for Managing Domains. Note that managing Domains requires the Platform Privileges 'Manage Domains'.
Part 2 of #3953.
Screenshots
Checklist