Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(domains): Adding UI for Asset Domains (P2) #3953

Closed
wants to merge 43 commits into from

Conversation

jjoyce0510
Copy link
Collaborator

Summary
This PR contains the UI for adding Domains to DataHub. It depends on the parent PR #3952

Changes

The specific changes in this PR include:

  1. Adding frontend Entity for Domain
  2. Adding search previews, profile, graphql queries required to fetch and render entity domains.

Status
Depends on parent PR

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results (build & test)

  9 files   -   36    9 suites   - 36   16s ⏱️ - 13m 8s
76 tests  - 428  76 ✔️  - 372  0 💤  - 56  0 ±0 

Results for commit c5fda75. ± Comparison against base commit 8b716ad.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   38m 38s ⏱️ +44s
   274 tests ±0     274 ✔️ ±0    0 💤 ±0  0 ±0 
1 261 runs  +2  1 233 ✔️ +8  28 💤  - 6  0 ±0 

Results for commit c5fda75. ± Comparison against base commit 8b716ad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant