Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-ui): fix header min height #3784

Merged
merged 1 commit into from
Dec 22, 2021
Merged

fix(react-ui): fix header min height #3784

merged 1 commit into from
Dec 22, 2021

Conversation

gabe-lyons
Copy link
Contributor

The header's height was capped at 137px. However, it may expand beyond that in the case of a very long title. This removes that limit.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results

     45 files  ±0       45 suites  ±0   50m 38s ⏱️ + 4m 52s
   644 tests ±0     592 ✔️ ±0  52 💤 ±0  0 ❌ ±0 
1 444 runs  +2  1 376 ✔️ +8  68 💤  - 6  0 ❌ ±0 

Results for commit 0d2bb86. ± Comparison against base commit e76d40b.

@shirshanka shirshanka merged commit 3860205 into datahub-project:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabe-lyons @shirshanka