fix(lkml): bump lkml version up to 1.1.2 to support sql_preamble expr…

…ession (#3757)
datahub-project · Dec 21, 2021 · e76d40b · e76d40b
1 parent 77e3641
commit e76d40b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/metadata-ingestion/setup.py b/metadata-ingestion/setup.py
@@ -111,7 +111,8 @@ def get_long_description():
     "kafka-connect": sql_common | {"requests", "JPype1"},
     "ldap": {"python-ldap>=2.4"},
     "looker": looker_common,
-    "lookml": looker_common | {"lkml>=1.1.0", "sql-metadata==2.2.2"},
+    # lkml>=1.1.2 is required to support the sql_preamble expression in LookML
+    "lookml": looker_common | {"lkml>=1.1.2", "sql-metadata==2.2.2"},
     "metabase": {"requests"},
     "mode": {"requests", "sqllineage"},
     "mongodb": {"pymongo>=3.11"},

diff --git a/...a-ingestion/tests/integration/lookml/lkml_samples/nested/included_sql_preamble.model.lkml b/...a-ingestion/tests/integration/lookml/lkml_samples/nested/included_sql_preamble.model.lkml
@@ -0,0 +1,10 @@
+connection: "my_connection"
+
+explore: included_sql_preamble {
+  sql_preamble:
+    CREATE TEMP FUNCTION CONCAT_VERBOSE(a STRING, b STRING)
+    RETURNS STRING AS (
+      CONCAT(a, b)
+    );
+  ;;
+}