Fix grid tessellate h3 res #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edurdevic
approved these changes
Dec 2, 2022
a0x8o
added a commit
to a0x8o/mosaic
that referenced
this pull request
Feb 22, 2023
Update version to 0.3.6-SNAPSHOT (databrickslabs#268) Update version to 0.3.5 (databrickslabs#267) Fix grid tessellate h3 res (databrickslabs#266) Feature/knn transformer (databrickslabs#258) Merge pull request databrickslabs#254 from databrickslabs/fix/duplicated_indexes
a0x8o
added a commit
to a0x8o/mosaic
that referenced
this pull request
Feb 22, 2023
Update version to 0.3.6-SNAPSHOT (databrickslabs#268) Update version to 0.3.5 (databrickslabs#267) Fix grid tessellate h3 res (databrickslabs#266)
sllynn
pushed a commit
that referenced
this pull request
Nov 20, 2023
* wip * fix buffer radius calculation * Revert "wip" This reverts commit 2736277. Co-authored-by: Tim Dikland <tim.dikland@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes calculation of the buffer radius used during tessellation with H3. Previous calculation assumed that the geometry representation of the cell boundary always contains 6 vertices. This is not always true (e.g. H3 grid cell gets crossed by projected edge of icosahedron)
Fixes #260