Fixed duplicated indexes #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #254 +/- ##
============================================
+ Coverage 87.25% 87.31% +0.06%
- Complexity 986 995 +9
============================================
Files 109 109
Lines 4387 4416 +29
Branches 393 396 +3
============================================
+ Hits 3828 3856 +28
Misses 268 268
- Partials 291 292 +1
|
milos-colic
suggested changes
Nov 11, 2022
| import com.databricks.labs.mosaic.expressions.constructors.ConstructorsBehaviors | ||
| import org.scalatest.flatspec.AnyFlatSpec | ||
|
|
||
| class TestMosaic extends AnyFlatSpec with ConstructorsBehaviors { |
There was a problem hiding this comment.
Can we please use the other test style.
We want to decommission AnyFlatSpecs.
There was a problem hiding this comment.
Please note that I am not testing any Spark transformation here, but only the logic of the chips deduplication of the tessellation code.
This specific test only makes sense with H3 and ESRI.
milos-colic
approved these changes
Nov 13, 2022
|
The check failed due to an issue on codecov side. |
a0x8o
added a commit
to a0x8o/mosaic
that referenced
this pull request
Feb 22, 2023
Update version to 0.3.6-SNAPSHOT (databrickslabs#268) Update version to 0.3.5 (databrickslabs#267) Fix grid tessellate h3 res (databrickslabs#266) Feature/knn transformer (databrickslabs#258) Merge pull request databrickslabs#254 from databrickslabs/fix/duplicated_indexes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #243