Add databricks_workspace_file resource
#2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With recent release of the workspace file support it's now possible to store arbitrary files in the workspace, not only notebooks. It's also recommended way to store init scripts to avoid security problems associated with storing init scripts on DBFS.
alexott
force-pushed
the
workspace-files-support
branch
from
ce30f6e to
9026889
Compare
nfx
requested changes
May 8, 2023
workspace/resource_workspace_file.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| notebooksAPI := NewNotebooksAPI(ctx, c) |
There was a problem hiding this comment.
SDK has to be used for all new resources.
There was a problem hiding this comment.
I wrote why it wasn't used :-)
There was a problem hiding this comment.
Please use the c.WorkspaceClient() instead of NewNotebooksAPI
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2266 +/- ##
==========================================
- Coverage 88.79% 88.74% -0.06%
==========================================
Files 139 140 +1
Lines 11477 11549 +72
==========================================
+ Hits 10191 10249 +58
- Misses 861 868 +7
- Partials 425 432 +7
|
nfx
requested changes
May 8, 2023
workspace/resource_workspace_file.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| notebooksAPI := NewNotebooksAPI(ctx, c) |
There was a problem hiding this comment.
Please use the c.WorkspaceClient() instead of NewNotebooksAPI
nfx
requested changes
May 8, 2023
workspace/resource_workspace_file.go
Outdated
| Path: path, | ||
| Overwrite: true, | ||
| } | ||
| err = notebooksAPI.Import(ctx, createNotebook) |
There was a problem hiding this comment.
client.Workspace.Import(ctx, ws_api.Import{
Content: base64.StdEncoding.EncodeToString(content),
Format: ws_api.ExportFormatAuto,
Path: path,
Overwrite: true,
})
workspace/resource_workspace_file.go
Outdated
| path := d.Get("path").(string) | ||
| parent := filepath.ToSlash(filepath.Dir(path)) | ||
| if parent != "/" { | ||
| err = notebooksAPI.MkdirsByPath(ctx, parent) |
There was a problem hiding this comment.
Suggested change
| err = notebooksAPI.MkdirsByPath(ctx, parent) | |
| err = client.Workspace..MkdirsByPath(ctx, parent) |
nfx
added a commit
that referenced
this pull request
May 12, 2023
# Version changelog ## 1.16.0 * Added [databricks_workspace_file](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/workspace_file) resource ([#2266](#2266)). * Added `notification_settings` block to [databricks_job](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/job) resource ([#2276](#2276)). * Added missing permission to [databricks_aws_crossaccount_policy](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/aws_crossaccount_policy) data source ([#2283](#2283)). * Fixed [databricks_sql_table](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_table) doc ([#2281](#2281)). * Fixed doc on tag propagation and tag conflict for [databricks_instance_pool](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/instance_pool) resource ([#2242](#2242)). * Document & export [databricks_workspace_conf](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/workspace_conf) parameters for legacy init scripts ([#2280](#2280)). * Removed deprecated `CREATE_VIEW` from code of [databricks_grants](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/grants) resource ([#2230](#2230)). * Exporter: relax handling of problematic files/directories ([#2258](#2258)).
Merged
nfx
added a commit
that referenced
this pull request
May 12, 2023
# Version changelog ## 1.16.0 * Added [databricks_workspace_file](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/workspace_file) resource ([#2266](#2266)). * Added `notification_settings` block to [databricks_job](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/job) resource ([#2276](#2276)). * Added missing permission to [databricks_aws_crossaccount_policy](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/aws_crossaccount_policy) data source ([#2283](#2283)). * Fixed [databricks_sql_table](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_table) doc ([#2281](#2281)). * Fixed doc on tag propagation and tag conflict for [databricks_instance_pool](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/instance_pool) resource ([#2242](#2242)). * Document & export [databricks_workspace_conf](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/workspace_conf) parameters for legacy init scripts ([#2280](#2280)). * Removed deprecated `CREATE_VIEW` from code of [databricks_grants](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/grants) resource ([#2230](#2230)). * Exporter: relax handling of problematic files/directories ([#2258](#2258)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With recent release of the workspace file support it's now possible to store arbitrary files in the workspace, not only notebooks. It's also recommended way to store init scripts to avoid security problems associated with storing init scripts on DBFS.
I deliberately didn't use the Go SDK as all code was already available. Migration to Go SDK will follow after discussions on the change required for supporting list command (see #2258)
This fixes #2206
Tests
make testrun locallydocs/folderinternal/acceptance