Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Is Object Id in Notebook Resource Deprecated #1939

Closed
stikkireddy opened this issue Jan 18, 2023 · 2 comments
Closed

[DOC] Is Object Id in Notebook Resource Deprecated #1939

stikkireddy opened this issue Jan 18, 2023 · 2 comments
Labels
docs add explicit documentation about corner case

Comments

@stikkireddy
Copy link
Contributor

stikkireddy commented Jan 18, 2023

Is the object_id attribute actually deprecated? It is a relevant guid for the object in the Databricks workspace directory.

Affected Resource(s)

databricks_notebook
databricks_permissions

We should either indicate that object_id is a deprecated field in the docs or un-deprecate the field otherwise. @nfx can you provide some commentary on this. This also impacts a valid path of databricks_permissions where you can identify the object via notebook_id rather than path which should also be deprecated if we choose to deprecate object_id.

https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/notebook#attribute-reference

Relevant code that adds deprecation:

"object_id": {
Type: schema.TypeInt,
Optional: true,
Computed: true,
Deprecated: "Use id argument to retrieve object id",
},

@iandexter iandexter added the docs add explicit documentation about corner case label Jan 19, 2023
@alexott
Copy link
Contributor

alexott commented Jan 25, 2023

we still need object ID for notebooks & directories export

@nkvuong
Copy link
Contributor

nkvuong commented Dec 4, 2023

Fixed by #2266

@nkvuong nkvuong closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs add explicit documentation about corner case
Projects
None yet
Development

No branches or pull requests

4 participants