Make bundle and sync fields optional #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
requested review from
pietern and
andrewnester
and removed request for
pietern
shreyas-goenka
commented
Sep 8, 2023
| @@ -1472,7 +1472,6 @@ | |||
| "config": { | |||
| "description": "The model serving endpoint configuration.", | |||
| "properties": { | |||
| "description": "", | |||
| "properties": { | |||
There was a problem hiding this comment.
Note: model serving docs are missing from the generated schema because the schema format here is incorrect. All this means is that the docs are not loaded, but the schema command still works correctly. I have filed a internal followup to fix these so the docs are loaded successfully.
For now, the description field was removed by hand.
andrewnester
approved these changes
Sep 8, 2023
lennartkats-db
approved these changes
Sep 11, 2023
pietern
approved these changes
Sep 11, 2023
pietern
added a commit
that referenced
this pull request
Sep 11, 2023
Bundles: * Fix conversion of job parameters ([#744](#744)). * Add schema and config validation to jsonschema package ([#740](#740)). * Support Model Serving Endpoints in bundles ([#682](#682)). * Do not include empty output in job run output ([#749](#749)). * Fixed marking libraries from DBFS as remote ([#750](#750)). * Process only Python wheel tasks which have local libraries used ([#751](#751)). * Add enum support for bundle templates ([#668](#668)). * Apply Python wheel trampoline if workspace library is used ([#755](#755)). * List available targets when incorrect target passed ([#756](#756)). * Make bundle and sync fields optional ([#757](#757)). * Consolidate environment variable interaction ([#747](#747)). Internal: * Update Go SDK to v0.19.1 ([#759](#759)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 11, 2023
Bundles: * Fix conversion of job parameters ([#744](#744)). * Add schema and config validation to jsonschema package ([#740](#740)). * Support Model Serving Endpoints in bundles ([#682](#682)). * Do not include empty output in job run output ([#749](#749)). * Fixed marking libraries from DBFS as remote ([#750](#750)). * Process only Python wheel tasks which have local libraries used ([#751](#751)). * Add enum support for bundle templates ([#668](#668)). * Apply Python wheel trampoline if workspace library is used ([#755](#755)). * List available targets when incorrect target passed ([#756](#756)). * Make bundle and sync fields optional ([#757](#757)). * Consolidate environment variable interaction ([#747](#747)). Internal: * Update Go SDK to v0.19.1 ([#759](#759)).
hectorcast-db
pushed a commit
that referenced
this pull request
Oct 13, 2023
## Changes This PR: 1. Makes the bundle and sync properties optional in the generated schema. 2. Fixes schema generation that was broken due to a rogue "description" field in the bundle docs. ## Tests Tested manually. The generated schema no longer has "bundle" and "sync" marked as required.
hectorcast-db
pushed a commit
that referenced
this pull request
Oct 13, 2023
Bundles: * Fix conversion of job parameters ([#744](#744)). * Add schema and config validation to jsonschema package ([#740](#740)). * Support Model Serving Endpoints in bundles ([#682](#682)). * Do not include empty output in job run output ([#749](#749)). * Fixed marking libraries from DBFS as remote ([#750](#750)). * Process only Python wheel tasks which have local libraries used ([#751](#751)). * Add enum support for bundle templates ([#668](#668)). * Apply Python wheel trampoline if workspace library is used ([#755](#755)). * List available targets when incorrect target passed ([#756](#756)). * Make bundle and sync fields optional ([#757](#757)). * Consolidate environment variable interaction ([#747](#747)). Internal: * Update Go SDK to v0.19.1 ([#759](#759)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR:
Tests
Tested manually. The generated schema no longer has "bundle" and "sync" marked as required.