Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process only Python wheel tasks which have local libraries used #751

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Process only Python wheel tasks which have local libraries used #751

merged 2 commits into from
Sep 8, 2023

Conversation

andrewnester
Copy link
Contributor

Changes

Process only Python wheel tasks which have local libraries used

Tests

Updated uni test to catch the regression

@andrewnester andrewnester requested a review from pietern September 8, 2023 10:20
pietern
pietern reviewed Sep 8, 2023
View reviewed changes
Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this work if you have a mix of both local and non-local wheels?

@andrewnester
Copy link
Contributor Author

andrewnester commented Sep 8, 2023 •
edited
Loading

How does this work if you have a mix of both local and non-local wheels?

@pietern it would work correctly if non local libraries are from pip compatible locations like PyPi, or Workspace FS.
If it mixes local and DBFS path, the task would indeed fail

@andrewnester andrewnester requested a review from pietern September 8, 2023 10:56
pietern
pietern approved these changes Sep 8, 2023
View reviewed changes
bundle/artifacts/whl/autodetect.go Outdated Show resolved Hide resolved
@andrewnester andrewnester added this pull request to the merge queue Sep 8, 2023
Merged via the queue into main with commit 67af171 Sep 8, 2023
@andrewnester andrewnester deleted the do-not-wrap-remote-libs branch September 8, 2023 11:17
pietern added a commit that referenced this pull request Sep 11, 2023
@pietern
Release v0.204.1
b668c64 
Bundles:
 * Fix conversion of job parameters ([#744](#744)).
 * Add schema and config validation to jsonschema package ([#740](#740)).
 * Support Model Serving Endpoints in bundles ([#682](#682)).
 * Do not include empty output in job run output ([#749](#749)).
 * Fixed marking libraries from DBFS as remote ([#750](#750)).
 * Process only Python wheel tasks which have local libraries used ([#751](#751)).
 * Add enum support for bundle templates ([#668](#668)).
 * Apply Python wheel trampoline if workspace library is used ([#755](#755)).
 * List available targets when incorrect target passed ([#756](#756)).
 * Make bundle and sync fields optional ([#757](#757)).
 * Consolidate environment variable interaction ([#747](#747)).

Internal:
 * Update Go SDK to v0.19.1 ([#759](#759)).
@pietern pietern mentioned this pull request Sep 11, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 11, 2023
@pietern
Release v0.204.1 (#763)
44726d6 
Bundles:
* Fix conversion of job parameters
([#744](#744)).
* Add schema and config validation to jsonschema package
([#740](#740)).
* Support Model Serving Endpoints in bundles
([#682](#682)).
* Do not include empty output in job run output
([#749](#749)).
* Fixed marking libraries from DBFS as remote
([#750](#750)).
* Process only Python wheel tasks which have local libraries used
([#751](#751)).
* Add enum support for bundle templates
([#668](#668)).
* Apply Python wheel trampoline if workspace library is used
([#755](#755)).
* List available targets when incorrect target passed
([#756](#756)).
* Make bundle and sync fields optional
([#757](#757)).
* Consolidate environment variable interaction
([#747](#747)).

Internal:
* Update Go SDK to v0.19.1
([#759](#759)).
hectorcast-db pushed a commit that referenced this pull request Oct 13, 2023
@pietern @hectorcast-db
Release v0.204.1 (#763)
c05231c 
Bundles:
* Fix conversion of job parameters
([#744](#744)).
* Add schema and config validation to jsonschema package
([#740](#740)).
* Support Model Serving Endpoints in bundles
([#682](#682)).
* Do not include empty output in job run output
([#749](#749)).
* Fixed marking libraries from DBFS as remote
([#750](#750)).
* Process only Python wheel tasks which have local libraries used
([#751](#751)).
* Add enum support for bundle templates
([#668](#668)).
* Apply Python wheel trampoline if workspace library is used
([#755](#755)).
* List available targets when incorrect target passed
([#756](#756)).
* Make bundle and sync fields optional
([#757](#757)).
* Consolidate environment variable interaction
([#747](#747)).

Internal:
* Update Go SDK to v0.19.1
([#759](#759)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietern pietern pietern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewnester @pietern