Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(planner): support limit for new planner #5301

Merged
merged 3 commits into from
May 12, 2022
Merged

feat(planner): support limit for new planner #5301

merged 3 commits into from
May 12, 2022

Conversation

fkuner
Copy link
Contributor

@fkuner fkuner commented May 11, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Support limit for new planner.

The pr don't support expr in limit and offset now

Changelog

  • New Feature

Related Issues

Fixes #5240

@fkuner fkuner requested a review from BohuTANG as a code owner May 11, 2022 11:50
@vercel
Copy link

vercel bot commented May 11, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) May 12, 2022 at 2:18AM (UTC)

@fkuner
Copy link
Contributor Author

fkuner commented May 11, 2022

/review @xudong963

@databend-bot databend-bot requested a review from xudong963 May 11, 2022 11:50
@databend-bot
Copy link
Member

Take the reviewer to xudong963

@fkuner
Copy link
Contributor Author

fkuner commented May 11, 2022

/review @sundy-li

@databend-bot
Copy link
Member

Take the reviewer to sundy-li

@databend-bot databend-bot requested a review from sundy-li May 11, 2022 11:51
@mergify
Copy link
Contributor

mergify bot commented May 11, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label May 11, 2022
@BohuTANG BohuTANG requested review from leiysky and removed request for BohuTANG May 11, 2022 11:52
@xudong963
Copy link
Member

Seems to support expr in limit(such as limit 1 + 1, or limit 5 / 2) need to change the logic of LimitTransform, any thought? @leiysky @sundy-li

@sundy-li
Copy link
Member

Seems to support expr in limit(such as limit 1 + 1, or limit 5 / 2) need to change the logic of LimitTransform, any thought? @leiysky @sundy-li

It might be done in expression constant folding rule ?

@xudong963
Copy link
Member

It might be done in expression constant folding rule ?

Oh, we can support it after we add constant folading rule in the new optimizer.

@fkuner fkuner force-pushed the feature-planner-limit branch from 55db2a1 to abfd626 Compare May 12, 2022 00:29
@fkuner fkuner force-pushed the feature-planner-limit branch from abfd626 to 05ebffc Compare May 12, 2022 01:18
@BohuTANG BohuTANG merged commit 6ae94bf into databendlabs:main May 12, 2022
@xudong963 xudong963 mentioned this pull request May 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li left review comments

@leiysky leiysky leiysky approved these changes

@BohuTANG BohuTANG BohuTANG approved these changes

@xudong963 xudong963 Awaiting requested review from xudong963

Assignees
No one assigned
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: limit for new planner
6 participants
@fkuner @databend-bot @xudong963 @sundy-li @BohuTANG @leiysky