add err info to avoid panic and delete heavy test

databendlabs · May 12, 2022 · abfd626 · abfd626
1 parent 5ba330f
commit abfd626
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 14 deletions.
diff --git a/query/src/sql/planner/binder/limit.rs b/query/src/sql/planner/binder/limit.rs
@@ -32,25 +32,19 @@ impl<'a> Binder {
         let type_checker = TypeChecker::new(bind_context, self.ctx.clone());
 
         let limit_cnt = match limit {
-            Some(Expr::Literal(x)) => Some(
-                type_checker
-                    .parse_literal(x, None)
-                    .unwrap()
-                    .as_u64()
-                    .unwrap() as usize,
-            ),
+            Some(Expr::Literal(x)) => {
+                let data = type_checker.parse_literal(x, None)?.as_u64()?;
+                Some(data as usize)
+            }
             Some(_) => {
                 return Err(ErrorCode::IllegalDataType("Unsupported limit type"));
             }
             None => None,
         };
 
         let offset_cnt = if let Some(Expr::Literal(x)) = offset {
-            type_checker
-                .parse_literal(x, None)
-                .unwrap()
-                .as_u64()
-                .unwrap() as usize
+            let data = type_checker.parse_literal(x, None)?.as_u64()?;
+            data as usize
         } else {
             0
         };

diff --git a/tests/suites/0_stateless/20+_others/20_0001_planner_v2.result b/tests/suites/0_stateless/20+_others/20_0001_planner_v2.result
@@ -190,4 +190,3 @@ new_planner
 7
 8
 9
-0
diff --git a/tests/suites/0_stateless/20+_others/20_0001_planner_v2.sql b/tests/suites/0_stateless/20+_others/20_0001_planner_v2.sql
@@ -108,6 +108,5 @@ select '=== Test offset ===';
 select number from numbers(10) order by number asc offset 5;
 select '===================';
 select number from numbers(10) order by number+number asc offset 5;
-select number from numbers(10000000000000) limit 1;
 
 set enable_planner_v2 = 0;