Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test case for upsert_table_option #2489

Merged

Conversation

flaneur2020
Copy link
Member

@flaneur2020 flaneur2020 commented Oct 28, 2021

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

this PR adds a simple write & read test case for upsert_table_option.

currently upsert_table_option is todo!() for MetaEmbbed yet, as meta_api_test_suite is reused for all the implementations for the MetaApi trait, we have to take a small workaround:

  1. change the todo!() to ErrorCode::UnImplemented
  2. ignore the assert statement if we got ErrorCode::UnImplemented

Changelog

  • Build/Testing/CI
  • Not for changelog (changelog entry is not required)

Related Issues

Fixes #2392

Test Plan

Unit Tests
Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot databend-bot added pr-build this PR changes build/testing/ci steps pr-not-for-changelog labels Oct 28, 2021
@flaneur2020 flaneur2020 force-pushed the add-ut-on-upsert-table-options branch 2 times, most recently from d48e016 to 874a156 Compare October 28, 2021 08:07
@flaneur2020 flaneur2020 force-pushed the add-ut-on-upsert-table-options branch from 874a156 to ca4e585 Compare October 28, 2021 08:08
@BohuTANG
Copy link
Member

/review @drmingdrmer

@databend-bot
Copy link
Member

Take the reviewer to drmingdrmer

@codecov-commenter
Copy link

Codecov Report

Merging #2489 (ca4e585) into main (f09aa2f) will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2489   +/-   ##
=====================================
  Coverage     72%     72%           
=====================================
  Files        643     643           
  Lines      36541   36542    +1     
=====================================
+ Hits       26362   26370    +8     
+ Misses     10179   10172    -7     
Impacted Files Coverage Δ
metasrv/src/api/http_service.rs 14% <0%> (-62%) ⬇️
query/src/common/mod.rs 72% <0%> (-18%) ⬇️
metasrv/src/api/http_service_test.rs 64% <0%> (-4%) ⬇️
query/src/clusters/cluster.rs 56% <0%> (-2%) ⬇️
query/src/api/http_service.rs 80% <0%> (+<1%) ⬆️
metasrv/src/meta_service/network.rs 79% <0%> (+<1%) ⬆️
common/management/src/namespace/namespace_mgr.rs 72% <0%> (+1%) ⬆️
metasrv/src/meta_service/raftmeta.rs 89% <0%> (+3%) ⬆️
metasrv/src/executor/action_handler.rs 96% <0%> (+3%) ⬆️
common/meta/raft-store/src/state_machine/sm.rs 94% <0%> (+4%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f09aa2f...ca4e585. Read the comment docs.

Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice shot!

A minimal update that makes things better.

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit c358f54 into databendlabs:main Oct 28, 2021
@flaneur2020
Copy link
Member Author

@drmingdrmer oh my, thank you for reminding, I appended a fix typo pr in #2497 >.<

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build this PR changes build/testing/ci steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There should be a unit test to the new API MetaApi::upsert_table_option().
5 participants