-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test case for upsert_table_option #2489
add test case for upsert_table_option #2489
Conversation
Thanks for the contribution! Please review the labels and make any necessary changes. |
d48e016
to
874a156
Compare
874a156
to
ca4e585
Compare
/review @drmingdrmer |
Take the reviewer to drmingdrmer |
Codecov Report
@@ Coverage Diff @@
## main #2489 +/- ##
=====================================
Coverage 72% 72%
=====================================
Files 643 643
Lines 36541 36542 +1
=====================================
+ Hits 26362 26370 +8
+ Misses 10179 10172 -7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice shot!
A minimal update that makes things better.
CI Passed |
@drmingdrmer oh my, thank you for reminding, I appended a fix typo pr in #2497 >.< |
I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/
Summary
this PR adds a simple write & read test case for
upsert_table_option
.currently
upsert_table_option
istodo!()
for MetaEmbbed yet, as meta_api_test_suite is reused for all the implementations for the MetaApi trait, we have to take a small workaround:todo!()
toErrorCode::UnImplemented
ErrorCode::UnImplemented
Changelog
Related Issues
Fixes #2392
Test Plan
Unit Tests
Stateless Tests