There should be a unit test to the new API MetaApi::upsert_table_option().

[drmingdrmer]

MetaApiTestSuite is the test suite for both embedded and remote MetaApi.

BTW, there should be a unit test to the new API upsert_table_option().

Originally posted by @drmingdrmer in #2355 (comment)

[dantengsky]

is upsert_table_option supposed to be replaced by upsert_table_option?

issue #2368

[drmingdrmer]

Yes.

[drmingdrmer]

If you're NOT gonna fix #2368 soon, there should be a unit test to ensure things are going right. Or no other change can be safely made to this part safely.

Otherwise, #2368 should be a high priority task to be closed as soon as possible, at least before creating more codes depending on it: #2383

[dantengsky]

upsert_table_option is implicitly tested by other unit test cases already

[drmingdrmer]

If you are not gonna add the test, I will do it or somebody else will help.
Do not close it.

Implicitly tested is not good enough for a such a core module.

[dantengsky]

appreciate it! please consider implementing upsert_table instead

[flaneur2020]

could I take this issue? I'd like to take more warm up issues on the databend project

[drmingdrmer]

@flaneur2020
Thank you man~.