Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve gc_dropped_table_by_id() method #16528

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Sep 26, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: Improve gc_dropped_table_by_id() method
  • Unify arguments using typed values:
    • Replace separate table id and name with &DBIdTableName
    • Use TableId type for table identification
  • Reorganize method structure for better clarity and maintainability

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Refactoring

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Sep 26, 2024
- Unify arguments using typed values:
  - Replace separate table id and name with &DBIdTableName
  - Use TableId type for table identification
- Reorganize method structure for better clarity and maintainability
@drmingdrmer drmingdrmer marked this pull request as ready for review September 26, 2024 13:37
@drmingdrmer drmingdrmer merged commit 27157a3 into databendlabs:main Sep 26, 2024
74 checks passed
@drmingdrmer drmingdrmer deleted the 142-xx branch September 26, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant