-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove pytest-asyncio #6063
remove pytest-asyncio #6063
Conversation
6991040
to
8042a7a
Compare
Unit Test Results 18 files ±0 18 suites ±0 8h 51m 53s ⏱️ - 12m 42s For more details on these failures, see this check. Results for commit 70ca320. ± Comparison against base commit 6e30766. ♻️ This comment has been updated with latest results. |
61554fe
to
15982cc
Compare
async with await LocalCluster( | ||
typo_kwarg="foo", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the asynchronous=True
kwarg was missing so this spawned a new thread
6762202
to
26ce9bb
Compare
the macos failures seem unrelated |
distributed/tests/test_preload.py
Outdated
assert s.foo == 1 | ||
assert "12345/preload" in log.getvalue() | ||
with socket.create_server(("127.0.0.1", 0)) as server_sock: | ||
await asyncio.gather(to_thread(preload), test()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be a more robust expression of the previous test, achieved by:
- Avoiding creating the preload application in a separate process
- Allowing a dynamically allocated port
OSX 3.9 not ci1 failure #6076 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once builds pass
gen_test doesn't transport marks correctly and so must be the first decorator applied to a test function also gen_test is stricter than pytest-asyncio it checks for leaky comms and threads, so we need to make sure resources are closed properly
f7da0a0
to
70ca320
Compare
test_client.py::test_reconnect timed out in py3.10 ci1 see also #6000 |
gen_test doesn't transport marks correctly and so must be the first
decorator applied to a test function
also gen_test is stricter than pytest-asyncio it checks for leaky comms and
threads, so we need to make sure resources are closed properly
pre-commit run --all-files