-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make test_reconnect async #6000
Conversation
This was flakey due to cleaning up resources. My experience is that making things async helps with this in general. I don't have strong confidence that this will fix the issue, but I do have mild confidence, and strong confidence that it won't hurt.
25f6966
to
9262524
Compare
Unit Test Results 18 files + 6 18 suites +6 9h 45m 12s ⏱️ + 3h 46m 11s For more details on these failures, see this check. Results for commit aa8c7d9. ± Comparison against base commit 2fbf9eb. ♻️ This comment has been updated with latest results. |
Planning to merge when CI finishes |
Nope, this still fails |
Merging when CI finishes |
This was flakey due to cleaning up resources. My experience is that making things async helps with this in general. I don't have strong confidence that this will fix the issue, but I do have mild confidence, and strong confidence that it won't hurt.
This was flakey due to cleaning up resources.
My experience is that making things async helps with this in general.
I don't have strong confidence that this will fix the issue, but I do
have mild confidence, and strong confidence that it won't hurt.
pre-commit run --all-files