Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variable #2461

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Remove unused variable #2461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
510c74d
Remove unused variable
bkonyi Jul 8, 2024
2cb60aa
Merge branch 'main' into fix_analysis_failure
bkonyi Jul 8, 2024
e62fd1b
Fix additional test failure
bkonyi Jul 8, 2024
b4c7024
Merge branch 'fix_analysis_failure' of github.com:dart-lang/webdev in…
bkonyi Jul 8, 2024
c79863e
Fix type
bkonyi Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dwds/test/instances/common/test_inspector.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,6 @@ Object? _getValue(InstanceRef instanceRef) {
final _dartCoreLibrary = 'dart:core';
final _dartInterceptorsLibrary = 'dart:_interceptors';
final _dartJsHelperLibrary = 'dart:_js_helper';
final _dartCollectionLibrary = 'dart:collection';
final _dartRuntimeLibrary = 'dart:_runtime';

final matchRecordClassName = 'Record';
Expand Down
4 changes: 2 additions & 2 deletions dwds/test/instances/common/type_inspection_common.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,11 +247,11 @@ void runTests({
await onBreakPoint('printSimpleLocalRecord', (event) async {
final frame = event.topFrame!.index!;
final instanceRef = await getInstanceRef(frame, '<int>{}.runtimeType');
expect(instanceRef, matchTypeInstanceRef('_IdentityHashSet<int>'));
expect(instanceRef, matchTypeInstanceRef('IdentitySet<int>'));

final instanceId = instanceRef.id!;
final instance = await getObject(instanceId);
expect(instance, matchTypeInstance('_IdentityHashSet<int>'));
expect(instance, matchTypeInstance('IdentitySet<int>'));

final classId = instanceRef.classRef!.id;
expect(await getObject(classId), matchTypeClass);
Expand Down
Loading