Remove unused variable #2461
Merged
Remove unused variable #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to #2458
jakemac53
approved these changes
Jul 8, 2024
…to fix_analysis_failure
|
Remaining failures appear to be unrelated to @Markzipan's earlier change. Will land this to clear some of the failures and work on resolving the remaining failures. |
|
Fwiw, I would file an issue on those tests and mark them as skipped (the message for that being a link to the issue). That way you can get the bots green to prevent further regressions and fix the tests when it makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes an additional failing test condition.
Follow up to #2458