Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lints, update all packages to latest lints #587

Merged
merged 3 commits into from
Sep 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/oauth2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
strategy:
fail-fast: false
matrix:
sdk: [3.0.0, dev]
sdk: [dev]
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
- uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672
Expand Down Expand Up @@ -62,7 +62,7 @@ jobs:
matrix:
# Add macos-latest and/or windows-latest if relevant for this package.
os: [ubuntu-latest]
sdk: [stable, beta]
sdk: [3.4, dev]
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
- uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672
Expand Down
4 changes: 2 additions & 2 deletions pkgs/cli_config/lib/src/config.dart
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class Config {

/// Constructs a config by parsing the three sources.
///
/// If provided, [commandLineDefines] must be a list of '<key>=<value>'.
/// If provided, [commandLineDefines] must be a list of `<key>=<value>`.
///
/// If provided, [workingDirectory] is used to resolves paths inside
/// [commandLineDefines].
Expand Down Expand Up @@ -120,7 +120,7 @@ class Config {

/// Constructs a config by parsing the three sources.
///
/// If provided, [commandLineDefines] must be a list of '<key>=<value>'.
/// If provided, [commandLineDefines] must be a list of `<key>=<value>`.
///
/// If provided, [workingDirectory] is used to resolves paths inside
/// [commandLineDefines].
Expand Down
4 changes: 2 additions & 2 deletions pkgs/extension_discovery/lib/extension_discovery.dart
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ final class Extension {
/// * [bool] (`true` or `false`),
/// * [String],
/// * [num] ([int] or [double]),
/// * [List<Object?>], and,
/// * [Map<String, Object?>].
/// * `List<Object?>`, and,
/// * `Map<String, Object?>`.
final Map<String, Object?> config;

Extension._({
Expand Down
4 changes: 2 additions & 2 deletions pkgs/extension_discovery/lib/src/yaml_config_format.dart
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ import 'package:yaml/yaml.dart'
/// * [bool] (`true` or `false`),
/// * [String],
/// * [num] ([int] or [double]),
/// * [List<Object?>], and,
/// * [Map<String, Object?>].
/// * `List<Object?>`, and,
/// * `Map<String, Object?>`.
Map<String, Object?> parseYamlFromConfigFile(String yamlString) {
final visited = <YamlNode>{};
Object? toPlainType(YamlNode n) {
Expand Down
1 change: 0 additions & 1 deletion pkgs/mime/lib/src/bound_multipart_stream.dart
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,6 @@ class BoundMultipartStream {
default:
// Should be unreachable.
assert(false);
break;
}

// Move to the next byte.
Expand Down
4 changes: 4 additions & 0 deletions pkgs/oauth2/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.0.4-wip

* Require Dart 3.4

## 2.0.3

* Require `package:http` v1.0.0
Expand Down
20 changes: 0 additions & 20 deletions pkgs/oauth2/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,34 +10,14 @@ analyzer:

linter:
rules:
- always_declare_return_types
- avoid_catching_errors
- avoid_dynamic_calls
- avoid_private_typedef_functions
- avoid_unused_constructor_parameters
- avoid_void_async
- cancel_subscriptions
- directives_ordering
- literal_only_boolean_expressions
- no_adjacent_strings_in_list
- no_runtimeType_toString
- omit_local_variable_types
- only_throw_errors
- package_api_docs
- prefer_asserts_in_initializer_lists
- prefer_const_constructors
- prefer_const_declarations
- prefer_relative_imports
- prefer_single_quotes
- sort_pub_dependencies
- test_types_in_equals
- throw_in_finally
- type_annotate_public_apis
- unawaited_futures
- unnecessary_await_in_return
- unnecessary_lambdas
- unnecessary_parenthesis
- unnecessary_statements
- use_is_even_rather_than_modulo
- use_string_buffers
- use_super_parameters
6 changes: 3 additions & 3 deletions pkgs/oauth2/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
name: oauth2
version: 2.0.3
version: 2.0.4-wip
description: >-
A client library for authenticating with a remote service via OAuth2 on
behalf of a user, and making authorized HTTP requests with the user's
OAuth2 credentials.
repository: https://github.com/dart-lang/tools/tree/main/pkgs/oauth2

environment:
sdk: ^3.0.0
sdk: ^3.4.0
mosuem marked this conversation as resolved.
Show resolved Hide resolved

dependencies:
collection: ^1.15.0
Expand All @@ -16,5 +16,5 @@ dependencies:
http_parser: ^4.0.0

dev_dependencies:
dart_flutter_team_lints: ^2.0.0
dart_flutter_team_lints: ^3.0.0
test: ^1.16.0
2 changes: 2 additions & 0 deletions pkgs/source_map_stack_trace/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
## 2.1.3-wip

## 2.1.2

* Require Dart 3.3.0
Expand Down
4 changes: 2 additions & 2 deletions pkgs/source_map_stack_trace/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: source_map_stack_trace
version: 2.1.2
version: 2.1.3-wip
description: A package for applying source maps to stack traces.
repository: https://github.com/dart-lang/tools/tree/main/pkgs/source_map_stack_trace

Expand All @@ -12,6 +12,6 @@ dependencies:
stack_trace: ^1.10.0

dev_dependencies:
dart_flutter_team_lints: ^2.0.0
dart_flutter_team_lints: ^3.0.0
source_span: ^1.8.0
test: ^1.16.0
Loading