Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lints, update all packages to latest lints #587

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Fix lints, update all packages to latest lints #587

merged 3 commits into from
Sep 11, 2024

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Sep 11, 2024

No description provided.

Copy link

github-actions bot commented Sep 11, 2024

PR Health

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
cli_config None 0.2.1-wip 0.2.1-wip 0.2.1-wip ✔️
extension_discovery None 2.0.1-wip 2.0.1-wip 2.0.1-wip ✔️
mime None 2.0.0-wip 2.0.0-wip 2.0.0-wip ✔️
oauth2 Breaking 2.0.3 2.0.4-wip 3.0.0
Got "2.0.4-wip" expected >= "3.0.0" (breaking changes)
⚠️
source_map_stack_trace None 2.1.2 2.1.3-wip 2.1.2 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Coverage ✔️
File Coverage
pkgs/cli_config/lib/src/config.dart 💚 100 %
pkgs/extension_discovery/lib/extension_discovery.dart 💚 81 %
pkgs/extension_discovery/lib/src/yaml_config_format.dart 💚 94 %
pkgs/mime/lib/src/bound_multipart_stream.dart 💚 89 %

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Package publish validation ✔️
Package Version Status
package:cli_config 0.2.1-wip WIP (no publish necessary)
package:coverage 1.9.2 already published at pub.dev
package:extension_discovery 2.0.1-wip WIP (no publish necessary)
package:graphs 2.3.3-wip WIP (no publish necessary)
package:mime 2.0.0-wip WIP (no publish necessary)
package:oauth2 2.0.4-wip WIP (no publish necessary)
package:source_map_stack_trace 2.1.3-wip WIP (no publish necessary)
package:unified_analytics 6.1.3 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Sep 11, 2024
@kevmoo kevmoo changed the title wip Fix lints, update all packages to latest lints Sep 11, 2024
@kevmoo kevmoo marked this pull request as ready for review September 11, 2024 16:48
@kevmoo kevmoo merged commit 23567be into main Sep 11, 2024
26 checks passed
@kevmoo kevmoo deleted the lint_cleanup branch September 11, 2024 20:52
mosuem added a commit to dart-lang/ecosystem that referenced this pull request Sep 23, 2024
See dart-lang/tools#587 (comment)

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Most changes should add an entry to the changelog and may need to [rev
the pubspec package
version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change).
- Changes to packages require [corresponding
tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing).

Note that many Dart repos have a weekly cadence for reviewing PRs -
please allow for some latency before initial review feedback.
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants